Message-ID: <gh-pgjdbc-pgjdbc-2646-rc1598702116@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Mon, 13 May 2024 15:53:49 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #2646: feat: improve libpq compatibility for URL parsing, environment variables, passfile, and property naming
In-Reply-To: <gh-pgjdbc-pgjdbc-2646-rc1598022853@github.com>
References: <gh-pgjdbc-pgjdbc-2646@github.com> <gh-pgjdbc-pgjdbc-2646-rc1598022853@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 1598702116
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 7db00b9839b123548eefdf3a1a72235505f23264
X-GitHub-Issue: 2646
X-GitHub-Path: README.md
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/2646#discussion_r1598702116
Content-Type: text/plain; charset=utf-8

(on README.md)

What I mean is that it would be better to phrase the features in terms of their usability.
The fact that environment variable can be set does not provide much to the end users.

It might be better to have something like "Some of the settings could be passed from environment variables as follows:..."