Message-ID: <gh-pgjdbc-pgjdbc-2646-rc1616829225@github.com>
From: "MarekUniq (@MarekUniq)" <noreply+MarekUniq@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Tue, 28 May 2024 08:38:21 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #2646: feat: improve libpq compatibility for URL parsing, environment variables, passfile, and property naming
In-Reply-To: <gh-pgjdbc-pgjdbc-2646-rc1615752582@github.com>
References: <gh-pgjdbc-pgjdbc-2646@github.com> <gh-pgjdbc-pgjdbc-2646-rc1615752582@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: MarekUniq
X-GitHub-Comment-Id: 1616829225
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 7db00b9839b123548eefdf3a1a72235505f23264
X-GitHub-Issue: 2646
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/PGEnvironment.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/2646#discussion_r1616829225
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/PGEnvironment.java)

There is no one constant default value for given parameter.
The default value is operating system specific.
**Yes, functionality is backward compatible (the same).**

**Can you recommend proper approach?**
This enum is not meant to be used outside pgjdbc driver.
There should not be any promises assumed regarding this enum outside pgjdbc driver.
At the same time I can not remove keyword `public`.
How could we avoid "backward compatible" questions which are relevant only because of technical restrictions?