Message-ID: <gh-pgjdbc-pgjdbc-2646-rc1622422131@github.com>
From: "MarekUniq (@MarekUniq)" <noreply+MarekUniq@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Fri, 31 May 2024 13:28:11 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #2646: feat: improve libpq compatibility for URL parsing, environment variables, passfile, and property naming
In-Reply-To: <gh-pgjdbc-pgjdbc-2646-rc1615752582@github.com>
References: <gh-pgjdbc-pgjdbc-2646@github.com> <gh-pgjdbc-pgjdbc-2646-rc1615752582@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: MarekUniq
X-GitHub-Comment-Id: 1622422131
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 7db00b9839b123548eefdf3a1a72235505f23264
X-GitHub-Issue: 2646
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/PGEnvironment.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/2646#discussion_r1622422131
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/PGEnvironment.java)

> ... is if the PR keeps full backward compatibility or if the breakage is minimal.

In my estimation, the real impact is close to zero.
The old value is incorrect and there is no common constant default value for this parameter across all operating systems.
If someone has adopted this default value and has tested their system, they must have realized that this value is wrong