Message-ID: <gh-pgjdbc-pgjdbc-2646-rc1625474996@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Tue, 04 Jun 2024 07:16:06 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #2646: feat: improve libpq compatibility for URL parsing, environment variables, passfile, and property naming
In-Reply-To: <gh-pgjdbc-pgjdbc-2646-rc1615752582@github.com>
References: <gh-pgjdbc-pgjdbc-2646@github.com> <gh-pgjdbc-pgjdbc-2646-rc1615752582@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 1625474996
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 7db00b9839b123548eefdf3a1a72235505f23264
X-GitHub-Issue: 2646
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/PGEnvironment.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/2646#discussion_r1625474996
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/PGEnvironment.java)

It does not have to work across all the OS. It might work for a single os, so changing default might break user's workfows.

We focus on backward compatibility, so breaking things like "property no longer used" or "enum entry no longer exists" makes it much harder to merge the change.

Could you please double-check if the PR maintains backward compatibility?