Message-ID: <gh-pgjdbc-pgjdbc-2646-rc1630714693@github.com>
From: "MarekUniq (@MarekUniq)" <noreply+MarekUniq@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Fri, 07 Jun 2024 06:35:56 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #2646: feat: improve libpq compatibility for URL parsing, environment variables, passfile, and property naming
In-Reply-To: <gh-pgjdbc-pgjdbc-2646-rc1615752582@github.com>
References: <gh-pgjdbc-pgjdbc-2646@github.com> <gh-pgjdbc-pgjdbc-2646-rc1615752582@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: MarekUniq
X-GitHub-Comment-Id: 1630714693
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 7db00b9839b123548eefdf3a1a72235505f23264
X-GitHub-Issue: 2646
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/PGEnvironment.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/2646#discussion_r1630714693
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/PGEnvironment.java)

The "old" default value is incorrect for all major operating systems: Linux, Windows, and MacOS.
A bit more correct value would be: `.pg_service.conf`
Correct value would be: `${HOME}/.pg_service.conf` for Linux/MacOS and `%APPDATA%\postgresql\.pg_service.conf` for Windows

I disagree that maintaining this incorrect default value is necessary, but since it seems to be a blocking issue, I have reverted code to keep the incorrect "old" default value.

Additionally, I have marked the `getDefaultValue()` function as deprecated.
This serves as a reminder that in the next major version, both the function and the incorrect default value may be removed from the code.