Message-ID: <gh-pgjdbc-pgjdbc-2741-rc1150509484@github.com>
From: "davecramer (@davecramer)" <noreply+davecramer@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Tue, 28 Mar 2023 12:17:17 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #2741: feat: add transaction isolation mode
In-Reply-To: <gh-pgjdbc-pgjdbc-2741@github.com>
References: <gh-pgjdbc-pgjdbc-2741@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: davecramer
X-GitHub-Comment-Id: 1150509484
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 454bc842871e863053908278567fd06d4397728d
X-GitHub-Issue: 2741
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/jdbc/PgConnection.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/2741#discussion_r1150509484
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/jdbc/PgConnection.java)

Does this change the current behaviour? Currently we throw an exception if the leveName is null. https://github.com/pgjdbc/pgjdbc/blob/3c3e5b62349c42d9d3dfe1fe0102776d4de8c353/pgjdbc/src/main/java/org/postgresql/jdbc/PgConnection.java#L1061