pgjdbc/pgjdbc GitHub issues and pull requests (mirror)  

help / color / mirror / Atom feed

From: davecramer (@davecramer) <[email protected]>
To: pgjdbc/pgjdbc <[email protected]>
Subject: Re: [pgjdbc/pgjdbc] issue #2918: Set defaultRowFetchSize=10000 by default to improve app stability
Date: Thu, 13 Jul 2023 11:33:41 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

> 



> The question what to do is quite complicated, but I'll try to voice some thoughts:
> 
> * specially for `INSERT` we can force fetchSize=0 at statement level - all rows to insert we already have in memory, so we can read all results at once
Not sure I'm a fan of this. You eventually find out how many rows it's just not from executeUpdate
> * we can make api more consistent - return always -1 for such cases `executeUpdate` with returning and add this to docs, but it will break a lot of code and third-party libraries, such as Exposed
Well if fetchSize is 0 it works properly
> * as more light version of previous one we can write about such situation to log and suggest to use `.execute`
Documenting the behaviour is my vote.

view thread (18+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: github://pgjdbc/pgjdbc
  Cc: [email protected], [email protected]
  Subject: Re: [pgjdbc/pgjdbc] issue #2918: Set defaultRowFetchSize=10000 by default to improve app stability
  In-Reply-To: <<[email protected]>>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox