Message-ID: <gh-pgjdbc-pgjdbc-2923-c1613460239@github.com>
From: "jrobe (@jrobe)" <noreply+jrobe@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Thu, 29 Jun 2023 16:00:28 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #2923: un-deprecate SSL_FACTORY_ARG
In-Reply-To: <gh-pgjdbc-pgjdbc-2923@github.com>
References: <gh-pgjdbc-pgjdbc-2923@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: jrobe
X-GitHub-Comment-Id: 1613460239
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 2923
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/2923#issuecomment-1613460239
Content-Type: text/plain; charset=utf-8

> If we add properties constructor, people might start using it, and it would be easier for them to configure, document, and understand.
> 
> For instance, `SingleCertValidatingFactory.tlsCertificate` property name would be much easier to find and understand in the documentation, internal wikis, emails, and StackOverflow than an obscure sslfactoryarg.

It's strange to me that the solution to the problem is "add another property" instead of support the existing one. Especially when the initial argument for marking it as deprecated was "there are too many properties" https://github.com/pgjdbc/pgjdbc/issues/1293