pgjdbc/pgjdbc GitHub issues and pull requests (mirror)
help / color / mirror / Atom feedFrom: jrobe (@jrobe) <[email protected]>
To: pgjdbc/pgjdbc <[email protected]>
Subject: Re: [pgjdbc/pgjdbc] PR #2923: un-deprecate SSL_FACTORY_ARG
Date: Thu, 29 Jun 2023 16:34:39 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
> Thread.stop has no bugs. It was deprecated for other reasons
Ok, that's tangential to this code review. And deprecation messages in Java's "Thread" class are different than this, because we (as developers) **know** that Java isn't going to just remove this, because they know that they can't break people's code. The problem with deprecation messages in other things (like the postgres library) is that we _don't_ know if deprecation means it's slotted for removal in the future, of if it's just not preferred. Not _preferred_ doesn't really warrant a deprecation tag for me; but perhaps a strongly worded java-doc.
My argument is since the BaseDataSource supports custom SSLFactories, and you've demonstrated a need to have arguments passed to those custom factories in your own SingleCertValidatingFactory, this property should live un-deprecated to support users to have an avenue of passing arguments to their own custom factories.
I need a way to do this in my code, and I'd prefer that way to not have a deprecation message and strike-through on the property name that I'm setting in this perfectly valid code (and a guarantee that when I update to some later postgres driver version that it won't all of a sudden disappear).
view thread (26+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: github://pgjdbc/pgjdbc
Cc: [email protected], [email protected]
Subject: Re: [pgjdbc/pgjdbc] PR #2923: un-deprecate SSL_FACTORY_ARG
In-Reply-To: <<[email protected]>>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox