Message-ID: <gh-pgjdbc-pgjdbc-2963-c1820397836@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Tue, 21 Nov 2023 07:50:46 +0000
Subject: Re: [pgjdbc/pgjdbc] issue #2963: BufferedOutputStream in PGStream should be replaced to something more efficient
In-Reply-To: <gh-pgjdbc-pgjdbc-2963@github.com>
References: <gh-pgjdbc-pgjdbc-2963@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 1820397836
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 2963
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/issues/2963#issuecomment-1820397836
Content-Type: text/plain; charset=utf-8

> Looking at PGStream more closely, it might make sense to move logic from sendInteger2 etc. to OutputStream

That sounds plausible.

> I'll add the modified benchmark.

Frankly, I suggest using JMH for the benchmark as it helps avoiding many pitfalls, and it has integrated support for profilers.
I might try doing it sometime later, however,  I would focus on reviewing and merging the outstanding PRs first.