Message-ID: <gh-pgjdbc-pgjdbc-3050-c2790543804@github.com>
From: "AllanBoydCA (@AllanBoydCA)" <noreply+AllanBoydCA@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Wed, 09 Apr 2025 18:07:39 +0000
Subject: Re: [pgjdbc/pgjdbc] issue #3050: Default driver settings can result in PII leakage
In-Reply-To: <gh-pgjdbc-pgjdbc-3050@github.com>
References: <gh-pgjdbc-pgjdbc-3050@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: AllanBoydCA
X-GitHub-Comment-Id: 2790543804
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 3050
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/issues/3050#issuecomment-2790543804
Content-Type: text/plain; charset=utf-8

Thanks for the quick response @vlsi and clarification. I see what you mean. 

pgJDBC driver is (obviously) a JDBC driver :), which I guess can be plugged into lots of other libraries since it's standard JDBC. Is that right? If so, then the application might be a bit far away from handling the exception sometimes. It might be that the exception is logged by a 3rd party configured to use pgJDBC e.g. [HikariCP](https://github.com/brettwooldridge/HikariCP). 

It's true what you say that use of ex.getMessage() is out of pgJDBC control. Would you disagree that by having logServerErrorDetail default to true, it is generally more likely that PII is leaked?

It may be the case of course that there are pgJDBC clients who rely logServerErrorDetail defaulting to true so I can imagine their might be reluctance to change the default setting.