pgjdbc/pgjdbc GitHub issues and pull requests (mirror)
help / color / mirror / Atom feedFrom: vlsi (@vlsi) <[email protected]>
To: pgjdbc/pgjdbc <[email protected]>
Subject: Re: [pgjdbc/pgjdbc] PR #3062: feat: type cache rework, codec API, and composite-type round-trip
Date: Thu, 14 May 2026 06:58:09 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
@davecramer , @sehrope , @bokken , The PR seems to add full Struct / Array support, proper type resolution (name -> oid), and SQLData support.
It looks like this goes in a pretty good shape modulo remaining cleanups 🎉 🎉 🎉
I still plan to review the changes after `docs: PGTYPE_SPEC overview` (those changes are "test failure fixes", "`@Nullable` fixes", etc).
The commits up to "docs: PGTYPE_SPEC overview" are coherently structured (I asked claude to restructure WIP commits), and the rest are fixups to be reviewed (and later squashed into the proper commits).
I plan to drop something like "hey, codex, the PR claims to support Struct/ Array / SQLData, so go ahead and generate user-level tests for it using JDBC / Hibernate / jOOQ / Spring Data ...". I'm not sure if it would identify meaningful issues, however, it could surface some.
I need to double-check `CallableStatements` as well (I haven't paid much attention to them).
I haven't paid attention to "structs/composites in updateable resultsets". It is yet another todo.
/cc @lukaseder. It would be nice to hear from you as well. Hopefully this should ease struct/array/binary handling with pgjdbc.
PS. To everybody: this is almost fully machine-generated code. I did review it, and I steered it. Sorry for issuing such a big change, however, I think it is ready for the general review. If you feel "oh, slop code detected", please ping me.
`PGTYPE_SPEC.md` is a part of the initial plan (a lot of iterations between claude and codex), and I intend to remove it.
view thread (32+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: github://pgjdbc/pgjdbc
Cc: [email protected], [email protected]
Subject: Re: [pgjdbc/pgjdbc] PR #3062: feat: type cache rework, codec API, and composite-type round-trip
In-Reply-To: <<[email protected]>>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox