Message-ID: <gh-pgjdbc-pgjdbc-3062-rc3241387988@github.com>
From: "sehrope (@sehrope)" <noreply+sehrope@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Thu, 14 May 2026 12:41:56 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3062: feat: type cache rework, codec API, and composite-type round-trip
In-Reply-To: <gh-pgjdbc-pgjdbc-3062@github.com>
References: <gh-pgjdbc-pgjdbc-3062@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: sehrope
X-GitHub-Comment-Id: 3241387988
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: c33a97c3b6666681715e237b1bf3109c7ef26840
X-GitHub-Issue: 3062
X-GitHub-Line: 21
X-GitHub-Path: pgjdbc-spring-jdbc-test/build.gradle.kts
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3062#discussion_r3241387988
Content-Type: text/plain; charset=utf-8

(on pgjdbc-spring-jdbc-test/build.gradle.kts:21)

Why are we adding spring-jdbc? We have a lot of the same stuff in our `TestUtil` helpers.

I'm not totally against adding it (*though less is more even for testing deps...*). But if we're going to do that, we should do it in its own PR knowing that it breaks back patching usage in tests for back branches unless we do it there as well.

If you can avoid using it it's preferable.