Message-ID: <gh-pgjdbc-pgjdbc-3062-rc3241420867@github.com>
From: "sehrope (@sehrope)" <noreply+sehrope@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Thu, 14 May 2026 12:47:47 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3062: feat: type cache rework, codec API, and composite-type round-trip
In-Reply-To: <gh-pgjdbc-pgjdbc-3062@github.com>
References: <gh-pgjdbc-pgjdbc-3062@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: sehrope
X-GitHub-Comment-Id: 3241420867
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: c33a97c3b6666681715e237b1bf3109c7ef26840
X-GitHub-Issue: 3062
X-GitHub-Line: 165
X-GitHub-Path: pgjdbc-spring-jdbc-test/src/test/java/org/postgresql/test/consumer/springjdbc/SpringJdbcCompositeConsumerTest.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3062#discussion_r3241420867
Content-Type: text/plain; charset=utf-8

(on pgjdbc-spring-jdbc-test/src/test/java/org/postgresql/test/consumer/springjdbc/SpringJdbcCompositeConsumerTest.java:165)

These tests should do this before the test starts too. Because otherwise if it crashes once and some of these object exist, the `CREATE ...` will fail with object already exists and test will not run. It's not an issue with a clean env like CI. But it can be annoying working locally if you ever CTRL-C the testing process (e.g., when testing out that interrupt stuff and it hangs forever running tests).

Not really specific to this either. I just noticed it here. We have lots of other tests that do this and we should clean those up too.