Message-ID: <gh-pgjdbc-pgjdbc-3062-rc3241736793@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Thu, 14 May 2026 13:42:26 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3062: feat: type cache rework, codec API, and composite-type round-trip
In-Reply-To: <gh-pgjdbc-pgjdbc-3062-rc3241387988@github.com>
References: <gh-pgjdbc-pgjdbc-3062@github.com> <gh-pgjdbc-pgjdbc-3062-rc3241387988@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 3241736793
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: c33a97c3b6666681715e237b1bf3109c7ef26840
X-GitHub-Issue: 3062
X-GitHub-Line: 21
X-GitHub-Path: pgjdbc-spring-jdbc-test/build.gradle.kts
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3062#discussion_r3241736793
Content-Type: text/plain; charset=utf-8

(on pgjdbc-spring-jdbc-test/build.gradle.kts:21)

>Why are we adding spring-jdbc? 

The idea is to test behavior from the users' point of view.
There might be corner-cases related to Spring's JDBC wrappers, and it makes sense testing them.

Spring itself does not have such tests: pgjdbc does not support structs/arrays, so Spring can't test them.

As time passes, we could donate the tests to Spring itself.

> it breaks back patching

I don't think we would ever back-patch the change.