Message-ID: <gh-pgjdbc-pgjdbc-3124-rc1507367091@github.com>
From: "minfrin (@minfrin)" <noreply+minfrin@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Thu, 29 Feb 2024 10:36:24 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3124: Add Windows and MacOS native certificate support
In-Reply-To: <gh-pgjdbc-pgjdbc-3124@github.com>
References: <gh-pgjdbc-pgjdbc-3124@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: minfrin
X-GitHub-Comment-Id: 1507367091
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 30087c24aeb8ac552664025c6f6d1c2ef3b86a5d
X-GitHub-Issue: 3124
X-GitHub-Line: 89
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/ssl/SSLFactory.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3124#discussion_r1507367091
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/ssl/SSLFactory.java:89)

I'm getting a test failure, more specifically a compilation failure that I don't understand.

```
[Task :postgresql:compileJava] [argument] incompatible argument for parameter arg1 of KeyManagerFactory.init.
      keyManagerFactory.init(keyStore, keyPassphrase);
                                       ^
  found   : @initialized @nonnull char @FBCBottom @nullable []
```

keyPassphrase is a char[], the extra annotations seem sane.

Can you confirm for me if possible what specifically is wrong with this line so I can fix it?