Message-ID: <gh-pgjdbc-pgjdbc-3141-rc1928291056@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Fri, 24 Jan 2025 08:06:47 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3141: Speed up getDate by parsing bytes instead of String
In-Reply-To: <gh-pgjdbc-pgjdbc-3141@github.com>
References: <gh-pgjdbc-pgjdbc-3141@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 1928291056
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 801bc33572548e0bc90e5463867daa7a7dce04ca
X-GitHub-Issue: 3141
X-GitHub-Line: 339
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/jdbc/ArrayDecoding.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3141#discussion_r1928291056
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/jdbc/ArrayDecoding.java:339)

I'm afraid I don't understand how this was supposed to improve the performance.
It seems extremely misleading to pass `byte[]`. Initially I thought it was supposed to be a `postgresql binary encoded value`, however, in practice it the method expects a sting in a format of `byte[]`.

Adding `.getBytes()` all over the place does not make life easier as well :-/