Message-ID: <gh-pgjdbc-pgjdbc-3141-rc1928308255@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Fri, 24 Jan 2025 08:23:01 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3141: Speed up getDate by parsing bytes instead of String
In-Reply-To: <gh-pgjdbc-pgjdbc-3141-rc1928291056@github.com>
References: <gh-pgjdbc-pgjdbc-3141@github.com> <gh-pgjdbc-pgjdbc-3141-rc1928291056@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 1928308255
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 801bc33572548e0bc90e5463867daa7a7dce04ca
X-GitHub-Issue: 3141
X-GitHub-Line: 339
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/jdbc/ArrayDecoding.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3141#discussion_r1928308255
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/jdbc/ArrayDecoding.java:339)

Ah, the core of the change is to avoid `byte[]->String->byte[]` when parsing `text-encoded` dates from the backend. However, it looks like the new implementation might affect cases like `getDate()` which falls back to `.getBytes()` extra conversion.