Message-ID: <gh-pgjdbc-pgjdbc-3171-rc2116533315@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Fri, 30 May 2025 19:43:39 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3171: validates resultsetParams in PGStatement constructor. uses assertThro…
In-Reply-To: <gh-pgjdbc-pgjdbc-3171@github.com>
References: <gh-pgjdbc-pgjdbc-3171@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 2116533315
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 2a2b207978331ee3d1d2a6f8ba6bae1dafe97d78
X-GitHub-Issue: 3171
X-GitHub-Line: 166
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/jdbc/PgStatement.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3171#discussion_r2116533315
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/jdbc/PgStatement.java:166)

Error message should better include the problematic value in question. The current error makes it hard to understand the reason for the failure.