Message-ID: <gh-pgjdbc-pgjdbc-3171@github.com>
From: "vishalvrv9 (@vishalvrv9)" <noreply+vishalvrv9@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Thu, 21 Mar 2024 15:22:03 +0000
Subject: [pgjdbc/pgjdbc] PR #3171: validates resultsetParams in PGStatement constructor. uses assertThro…
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Id: 21003730
X-GitHub-Author-Login: vishalvrv9
X-GitHub-Issue: 3171
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-State: merged
X-GitHub-Type: pull_request
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3171
Content-Type: text/plain; charset=utf-8

@vlsi @davecramer @sehrope 

This PR adheres to review comments provided in #3167 

- Validation of resultset params is done at the PgStatement constructor as PgPreparedStatement and PgCallableStatement inherit from there and the validation holds true at the base level
- localized messages are provided. Instead of SQL Exception, using PSQLException with invalid param errorcode
- tests now use assertThrows instead of fail

```./gradlew test```, ```./gradlew build```, and  ```./gradlew styleCheck``` are all passing