Message-ID: <gh-pgjdbc-pgjdbc-3220-c2100518371@github.com>
From: "arons (@arons)" <noreply+arons@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Wed, 08 May 2024 12:56:38 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3220:  setTimestamp use timestamptz db type
In-Reply-To: <gh-pgjdbc-pgjdbc-3220@github.com>
References: <gh-pgjdbc-pgjdbc-3220@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: arons
X-GitHub-Comment-Id: 2100518371
X-GitHub-Comment-Type: issue_comment
X-GitHub-Edited-At: 2024-05-08T13:07:10Z
X-GitHub-Issue: 3220
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3220#issuecomment-2100518371
Content-Type: text/plain; charset=utf-8

> There are cases like `select ?` and `select pg_typeof(?)`, and I believe they are not quite niche, so we should not consider them as the primary driving factor.

testTypeOnDbSite_functionOverloading and  testTypeOnDbSite_select are less trivial once already.

In the current implementation:
The first: it takes the worng function implementation in case of overloading.
The second:  throw an exception if  we try to add an interval to a timestamp passed parameter.


It should fix also the issue https://github.com/pgjdbc/pgjdbc/issues/1325 (also in the test case, no error any more in invoking the setObject method  )