Message-ID: <gh-pgjdbc-pgjdbc-3220-rc1592228836@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Tue, 07 May 2024 10:39:51 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3220:  setTimestamp use timestamptz db type
In-Reply-To: <gh-pgjdbc-pgjdbc-3220@github.com>
References: <gh-pgjdbc-pgjdbc-3220@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 1592228836
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 81b5dbb2c2903ec33cbcc2aab6535f33fe79d80a
X-GitHub-Issue: 3220
X-GitHub-Path: pgjdbc/src/test/java/org/postgresql/test/jdbc2/TimestamptzTest.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3220#discussion_r1592228836
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/test/java/org/postgresql/test/jdbc2/TimestamptzTest.java)

Please avoid `fail(e.getMessage());` pattern as it adds no extra value, and it hides the stacktrace. In cases like this just let the exception propagate, and do not catch it.