Message-ID: <gh-pgjdbc-pgjdbc-3232-rc1581875373@github.com>
From: "davecramer (@davecramer)" <noreply+davecramer@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Sat, 27 Apr 2024 18:06:53 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3232: add windows-latest as it supports docker
In-Reply-To: <gh-pgjdbc-pgjdbc-3232-rc1581833189@github.com>
References: <gh-pgjdbc-pgjdbc-3232@github.com> <gh-pgjdbc-pgjdbc-3232-rc1581833189@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: davecramer
X-GitHub-Comment-Id: 1581875373
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 3dc67d8a10ecfbe2b97895b267407f1da316e29c
X-GitHub-Issue: 3232
X-GitHub-Line: 101
X-GitHub-Path: .github/workflows/main.yml
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3232#discussion_r1581875373
Content-Type: text/plain; charset=utf-8

(on .github/workflows/main.yml:101)

> Ah that's interesting. So this would be testing some JDK running on Windows vs a Linux Postgres running in Docker?
> 
> If we're going to test against Windows (i.e. duplicate what's in AppVeyor), could have a separate branch for the server itself running on Windows. The GitHub Runner installed software list for "windows-2022" says that it already has PostgreSQL 14.x installed: https://github.com/actions/runner-images/blob/main/images/windows/Windows2022-Readme.md#databases
> 
> I think we'd be kind of tied to whatever they include in the runner image, but that's not any worse than what we have in AppVeyor. With the advantage that it'd work for forks too.

Yeah, well ideally we want to be able to test windows with different PostgreSQL versions. If we just want v14 then we can use whatever is there