Message-ID: <gh-pgjdbc-pgjdbc-3244-c2106257668@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Sun, 12 May 2024 14:04:05 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3244: refactor: use oid=?::regtype when fetching pg_type by name instead of joining pg_namespace
In-Reply-To: <gh-pgjdbc-pgjdbc-3244@github.com>
References: <gh-pgjdbc-pgjdbc-3244@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 2106257668
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 3244
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3244#issuecomment-2106257668
Content-Type: text/plain; charset=utf-8

The change is not compatible with the previous behavior. However, I believe the incompatibility is subtle enough so we can ship it without a connection property.

The database uses `search_path` to lookup the type, however, previously a type from any schema could match.

See https://github.com/pgjdbc/pgjdbc/commit/b383f6d2c8f19e2b5b867039ca96071ba8d495e1

I think we should follow the DB behavior, and we should support only the types listed on the `search_path` (== use DB's `::regtype` cast)