Message-ID: <gh-pgjdbc-pgjdbc-3249-rc1650147461@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Sun, 23 Jun 2024 17:41:17 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3249: perf: optimize Set<Integer> which are used for checking if oid should be transferred with binary or text
In-Reply-To: <gh-pgjdbc-pgjdbc-3249-rc1645287618@github.com>
References: <gh-pgjdbc-pgjdbc-3249@github.com> <gh-pgjdbc-pgjdbc-3249-rc1645287618@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 1650147461
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 3de0910ce64a0cfe93392e38792b6520fad0979d
X-GitHub-Issue: 3249
X-GitHub-Line: 51
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/util/internal/IntSet.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3249#discussion_r1650147461
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/util/internal/IntSet.java:51)

The parameter type is not nullable (`Collection<? extends Integer>` vs `Collection<? extends @Nullable Integer>`)