Message-ID: <gh-pgjdbc-pgjdbc-3306-c3828793026@github.com>
From: "binoverfl0w (@binoverfl0w)" <noreply+binoverfl0w@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Sat, 31 Jan 2026 16:32:05 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3306: feat: add support for reading / creating structs
In-Reply-To: <gh-pgjdbc-pgjdbc-3306@github.com>
References: <gh-pgjdbc-pgjdbc-3306@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: binoverfl0w
X-GitHub-Comment-Id: 3828793026
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 3306
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3306#issuecomment-3828793026
Content-Type: text/plain; charset=utf-8

@davecramer that test fails due to a bug on Array encoding which we encountered when working on this feature. Should be fixed by this PR: https://github.com/pgjdbc/pgjdbc/pull/3337.
If you apply these changes locally the test will fail at `assertEquals(s, item);`, reason being that in the discussion above it was agreed that we should not be handling struct equality due to the complexity it may introduce.
However, the string equality should hold, so `assertEquals(s.toString(), item.toString());` should pass.