Message-ID: <gh-pgjdbc-pgjdbc-3369-c2740908550@github.com>
From: "kimjand (@kimjand)" <noreply+kimjand@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Thu, 20 Mar 2025 15:45:55 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3369: fix: EOFException on PreparedStatement#toString with unset bytea parameter since 42.7.4
In-Reply-To: <gh-pgjdbc-pgjdbc-3369@github.com>
References: <gh-pgjdbc-pgjdbc-3369@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: kimjand
X-GitHub-Comment-Id: 2740908550
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 3369
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3369#issuecomment-2740908550
Content-Type: text/plain; charset=utf-8

On 20-03-2025 14:32, Rico Neubauer wrote:
>             Could you keep the old method names and signatures?
> 
>         @kimjand <https://github.com/kimjand> added a method, that
>         differs from existing one (see javadoc), not sure what you @vlsi
>         <https://github.com/vlsi> mean with keeping the old names?
> 
>     Instead of using toStringLiteral() use toString()
> 
>  From javadoc, I'd assume this was on purpose. @kimjand <https:// 
> github.com/kimjand> could you comment on this?
> 

Yes, this was completely intentional. The core of this bug is that the 
driver can't decide on what the methods are supposed to do. ToString 
claims it provides human readable output, but the driver expects it to 
contain literals for the parameter values.
Now there is a clear distinction between the two cases.