Message-ID: <gh-pgjdbc-pgjdbc-3369-rc2091623783@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Thu, 15 May 2025 16:59:55 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3369: fix: EOFException on PreparedStatement#toString with unset bytea parameter since 42.7.4
In-Reply-To: <gh-pgjdbc-pgjdbc-3369@github.com>
References: <gh-pgjdbc-pgjdbc-3369@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 2091623783
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 7ad73fc304676b98baa2c421a13cb5e9e3c0be06
X-GitHub-Issue: 3369
X-GitHub-Line: 11
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/core/v3/SqlSerializationContext.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3369#discussion_r2091623783
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/core/v3/SqlSerializationContext.java:11)

@bokken , @sehrope , WDYT of this?
I'm not sure regarding the name, however, I like the interface approach better than two methods `toString` and `toExecutableSql`.