pgjdbc/pgjdbc GitHub issues and pull requests (mirror)
help / color / mirror / Atom feed[pgjdbc/pgjdbc] PR #3386: Fix getSchemas()
11+ messages / 4 participants
[nested] [flat]
* [pgjdbc/pgjdbc] PR #3386: Fix getSchemas()
@ 2024-09-20 17:49 "SophiahHo (@SophiahHo)" <[email protected]>
0 siblings, 0 replies; 11+ messages in thread
From: SophiahHo (@SophiahHo) @ 2024-09-20 17:49 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
Fixes https://github.com/pgjdbc/pgjdbc/issues/3385 "Column alias names for metadata returned by getSchemas() violate JDBC spec"
### All Submissions:
* [x] Have you followed the guidelines in our [Contributing](https://github.com/pgjdbc/pgjdbc/blob/master/CONTRIBUTING.md) document?
* [x] Have you checked to ensure there aren't other open [Pull Requests](../../pulls) for the same update/change?
<!-- You can erase any parts of this template not applicable to your Pull Request. -->
### Changes to Existing Features:
* [ ] Does this break existing behaviour? If so please explain.
* [x] Have you added an explanation of what your changes do and why you'd like us to include them?
* [ ] Have you written new tests for your core changes, as applicable?
* [ ] Have you successfully run tests with your changes locally?
^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3386: Fix getSchemas()
@ 2024-09-20 19:13 ` "davecramer (@davecramer)" <[email protected]>
9 siblings, 0 replies; 11+ messages in thread
From: davecramer (@davecramer) @ 2024-09-20 19:13 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
@SophiahHo
Thanks for the PR. I think there are a few other places that need to have the same applied.
Also wouldn't https://github.com/pgjdbc/pgjdbc/blob/0f6bf16878de50d82c8c59a7d1da1b5641c084be/pgjdbc/src/main/java/... need to be fixed ?
^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3386: Fix getSchemas()
@ 2024-09-20 19:49 ` "SophiahHo (@SophiahHo)" <[email protected]>
9 siblings, 0 replies; 11+ messages in thread
From: SophiahHo (@SophiahHo) @ 2024-09-20 19:49 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
@davecramer Fixed the ORDER BY clause. Do I need to fix all the other places before this PR is approved?
^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3386: Fix getSchemas()
@ 2024-09-20 20:57 ` "davecramer (@davecramer)" <[email protected]>
9 siblings, 0 replies; 11+ messages in thread
From: davecramer (@davecramer) @ 2024-09-20 20:57 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
> @davecramer Fixed the ORDER BY clause. Do I need to fix all the other places before this PR is approved?
I would certainly appreciate it if you did.
^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3386: Fix getSchemas()
@ 2024-09-21 09:34 ` "jorsol (@jorsol)" <[email protected]>
9 siblings, 0 replies; 11+ messages in thread
From: jorsol (@jorsol) @ 2024-09-21 09:34 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
Also some tests would be nice.
^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3386: Fix getSchemas()
@ 2024-09-25 15:38 ` "SophiahHo (@SophiahHo)" <[email protected]>
9 siblings, 0 replies; 11+ messages in thread
From: SophiahHo (@SophiahHo) @ 2024-09-25 15:38 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
@davecramer I fixed it in the other places. Please approve.
^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3386: Fix getSchemas()
@ 2025-01-15 09:11 ` "lukaseder (@lukaseder)" <[email protected]>
9 siblings, 0 replies; 11+ messages in thread
From: lukaseder (@lukaseder) @ 2025-01-15 09:11 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
While I agree with the fix per se, I find the change to be quite significant in a patch release. It will break all sorts of client code, e.g.:
- https://github.com/jOOQ/jOOQ/issues/17873
In particular, it absolutely does break existing behaviour!
> * Does this break existing behaviour? If so please explain.
^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3386: Fix getSchemas()
@ 2025-01-16 13:58 ` "davecramer (@davecramer)" <[email protected]>
9 siblings, 0 replies; 11+ messages in thread
From: davecramer (@davecramer) @ 2025-01-16 13:58 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
Ya, sorry about that. In general we consider fixing things to meet the JDBC spec to be a bug rather than a feature. Agreed it's on the edge.
^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3386: Fix getSchemas()
@ 2025-02-10 19:54 ` "davecramer (@davecramer)" <[email protected]>
9 siblings, 0 replies; 11+ messages in thread
From: davecramer (@davecramer) @ 2025-02-10 19:54 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
@SophiahHo I don't think the fix for getCatalogs() is correct. There is only one catalog in the connection.
^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3386: Fix getSchemas()
@ 2025-02-10 22:19 ` "SophiahHo (@SophiahHo)" <[email protected]>
9 siblings, 0 replies; 11+ messages in thread
From: SophiahHo (@SophiahHo) @ 2025-02-10 22:19 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
@davecramer The [getCatalogs() change to return all catalogs](https://github.com/pgjdbc/pgjdbc/commit/9ea59bd87f7920f1c2aba20ffef15acef85def60) was committed by someone else (not me) in 2023, and it relates to https://github.com/pgjdbc/pgjdbc/pull/3390 instead of this PR. https://github.com/pgjdbc/pgjdbc/issues/3389#issuecomment-2414487622 explains the interaction.
^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3386: Fix getSchemas()
@ 2025-02-10 23:48 ` "davecramer (@davecramer)" <[email protected]>
9 siblings, 0 replies; 11+ messages in thread
From: davecramer (@davecramer) @ 2025-02-10 23:48 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
@SophiahHo you are correct, sorry for calling you out there.
^ permalink raw reply [nested|flat] 11+ messages in thread
end of thread, other threads:[~2025-02-10 23:48 UTC | newest]
Thread overview: 11+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-09-20 17:49 [pgjdbc/pgjdbc] PR #3386: Fix getSchemas() "SophiahHo (@SophiahHo)" <[email protected]>
2024-09-20 19:13 ` "davecramer (@davecramer)" <[email protected]>
2024-09-20 19:49 ` "SophiahHo (@SophiahHo)" <[email protected]>
2024-09-20 20:57 ` "davecramer (@davecramer)" <[email protected]>
2024-09-21 09:34 ` "jorsol (@jorsol)" <[email protected]>
2024-09-25 15:38 ` "SophiahHo (@SophiahHo)" <[email protected]>
2025-01-15 09:11 ` "lukaseder (@lukaseder)" <[email protected]>
2025-01-16 13:58 ` "davecramer (@davecramer)" <[email protected]>
2025-02-10 19:54 ` "davecramer (@davecramer)" <[email protected]>
2025-02-10 22:19 ` "SophiahHo (@SophiahHo)" <[email protected]>
2025-02-10 23:48 ` "davecramer (@davecramer)" <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox