Message-ID: <gh-pgjdbc-pgjdbc-3390-c2385841085@github.com>
From: "SophiahHo (@SophiahHo)" <noreply+SophiahHo@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Tue, 01 Oct 2024 13:24:06 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3390: Fix PgDatabaseMetaData implementation of catalog as param and return value
In-Reply-To: <gh-pgjdbc-pgjdbc-3390@github.com>
References: <gh-pgjdbc-pgjdbc-3390@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: SophiahHo
X-GitHub-Comment-Id: 2385841085
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 3390
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3390#issuecomment-2385841085
Content-Type: text/plain; charset=utf-8

I removed the empty string check for `schemaPattern`, because no rows should be returned if `schemaPattern` is an empty string per JDBC spec.
 
> schemaPattern - a schema name; must match the schema name as it is stored in the database; null means schema name should not be used to narrow down the search.

Please approve.