Message-ID: <gh-pgjdbc-pgjdbc-3390-rc1778764209@github.com>
From: "SophiahHo (@SophiahHo)" <noreply+SophiahHo@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Fri, 27 Sep 2024 15:03:06 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3390: Fix PgDatabaseMetaData implementation of catalog as param and return value
In-Reply-To: <gh-pgjdbc-pgjdbc-3390-rc1777767617@github.com>
References: <gh-pgjdbc-pgjdbc-3390@github.com> <gh-pgjdbc-pgjdbc-3390-rc1777767617@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: SophiahHo
X-GitHub-Comment-Id: 1778764209
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: d3a7a84222e227831e5894b7b64e11e40dbaae8e
X-GitHub-Issue: 3390
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/jdbc/PgDatabaseMetaData.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3390#discussion_r1778764209
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/jdbc/PgDatabaseMetaData.java)

If `catalog` is `""`, then getSchemas should return schemas "without a catalog" per [JDBC spec:](https://docs.oracle.com/en/java/javase/17/docs/api/java.sql/java/sql/DatabaseMetaData.html#getSchemas(java.lang.String,java.lang.String))

> catalog - a catalog name; must match the catalog name as it is stored in the database;"" retrieves those without a catalog; null means catalog name should not be used to narrow down the search.