Message-ID: <gh-pgjdbc-pgjdbc-3390-rc1878728339@github.com>
From: "SophiahHo (@SophiahHo)" <noreply+SophiahHo@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Tue, 10 Dec 2024 19:45:07 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3390: Fix PgDatabaseMetaData implementation of catalog as param and return value
In-Reply-To: <gh-pgjdbc-pgjdbc-3390-rc1878605572@github.com>
References: <gh-pgjdbc-pgjdbc-3390@github.com> <gh-pgjdbc-pgjdbc-3390-rc1878605572@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: SophiahHo
X-GitHub-Comment-Id: 1878728339
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: d3a7a84222e227831e5894b7b64e11e40dbaae8e
X-GitHub-Issue: 3390
X-GitHub-Line: 283
X-GitHub-Path: pgjdbc/src/test/java/org/postgresql/test/jdbc2/DatabaseMetaDataTest.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3390#discussion_r1878728339
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/test/java/org/postgresql/test/jdbc2/DatabaseMetaDataTest.java:283)

@davecramer Per https://docs.oracle.com/javase/8/docs/api/java/sql/DatabaseMetaData.html#getColumns-java.lang.String-java.lang.String-java.lang.String-java.lang.String- : 
> Parameters:
catalog - a catalog name; must match the catalog name as it is stored in the database; "" retrieves those without a catalog; null means that the catalog name should not be used to narrow the search
schemaPattern - a schema name pattern; must match the schema name as it is stored in the database; "" retrieves those without a schema; null means that the schema name should not be used to narrow the search

Searching with an empty catalog and schema should return no results. If you don't want the change in behaviour for how empty strings are handled, I can remove it, because it's not a priority for me/us. However, the current behaviour technically violates the JDBC spec.