Message-ID: <gh-pgjdbc-pgjdbc-3396-c2403470361@github.com>
From: "crowmagnumb (@crowmagnumb)" <noreply+crowmagnumb@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Wed, 09 Oct 2024 21:35:18 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3396: SQLData Support
In-Reply-To: <gh-pgjdbc-pgjdbc-3396@github.com>
References: <gh-pgjdbc-pgjdbc-3396@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: crowmagnumb
X-GitHub-Comment-Id: 2403470361
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 3396
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3396#issuecomment-2403470361
Content-Type: text/plain; charset=utf-8

OK, I think this is my actual proposal and just need to add tests. I am not implementing anything that the PgResultSet itself does not implement. In addition, I did not implement readBlob(), readClob(), and readArray() as the PgResultSet implementations of this all rely on the oid of the column which doesn't apply here and so that code would have to be reviewed to figure out how to create these objects without relying on that param. But otherwise I think this is a go.