Message-ID: <gh-pgjdbc-pgjdbc-3396-c2441227160@github.com>
From: "JavaUnchained (@JavaUnchained)" <noreply+JavaUnchained@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Mon, 28 Oct 2024 10:43:54 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3396: SQLData Support
In-Reply-To: <gh-pgjdbc-pgjdbc-3396@github.com>
References: <gh-pgjdbc-pgjdbc-3396@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: JavaUnchained
X-GitHub-Comment-Id: 2441227160
X-GitHub-Comment-Type: issue_comment
X-GitHub-Edited-At: 2024-10-28T15:00:16Z
X-GitHub-Issue: 3396
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3396#issuecomment-2441227160
Content-Type: text/plain; charset=utf-8

Hi. I think the problem with the array is due to the fact that the OID is specified for a simple TEXT and not TEXT_ARRAY, so TypeInfo does not return anything in response to getPGArrayElement . But this does not solve the typing problem.


If we had a buildArray map with only 1 element in it, then everything would be pretty trivial and would look something like this (below are just thoughts) :

```
private Object buildArray(ArrayDecoding.PgArrayList input, int index, int count, @Nullable Map<String, Class<?>> map) throws SQLException {
    final BaseConnection connection = getConnection();
    int elementOid = 0; // unspecified
    if (map != null && typeMap.size() == 1) {
      Optional<Map.Entry<String, Class<?>>> entryOp = typeMap.entrySet().stream().findFirst();
      if (entryOp.isPresent()) {
        Map.Entry<String, Class<?>> entry = entryOp.get();
        if (SQLData.class.isAssignableFrom(entry.getValue()) || connection.getTypeInfo().getPGType(entry.getKey()) != 0) { 
          elementOid = connection.getTypeInfo().getPGType(entry.getKey());
        }
      }
    }
    Object array = ArrayDecoding.readStringArray(index, count, elementOid , input, connection);
```
But I also doubt that someone will specify not UDT in the map, but simple types too

p.s I'm sorry for writing this here. I'm just very interested in the functionality that you've implemented.