Message-ID: <gh-pgjdbc-pgjdbc-3396-c2487925789@github.com>
From: "JavaUnchained (@JavaUnchained)" <noreply+JavaUnchained@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Wed, 20 Nov 2024 08:51:40 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3396: SQLData Support
In-Reply-To: <gh-pgjdbc-pgjdbc-3396@github.com>
References: <gh-pgjdbc-pgjdbc-3396@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: JavaUnchained
X-GitHub-Comment-Id: 2487925789
X-GitHub-Comment-Type: issue_comment
X-GitHub-Edited-At: 2024-11-20T08:53:16Z
X-GitHub-Issue: 3396
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3396#issuecomment-2487925789
Content-Type: text/plain; charset=utf-8

Please note that this piece of code probably doesn't work the way you expect
```
        if (isWhitespace(ch)) {
          ++charIdx;
          while (charIdx < len && isWhitespace(value.charAt(charIdx))) {
            ++charIdx;
          }
          break;
        }
```

You can run the method on such a line, for example, and verify this:
```
"(   "a"    ,   "b"   ,    "c"    )"
```
This code should find the index of the next non-whitespace character and call cotninue.

And there is no need for a go-to label in this method. You can do without the label in readString too by replacing switch with if-else