Message-ID: <gh-pgjdbc-pgjdbc-3396-c2584698459@github.com>
From: "crowmagnumb (@crowmagnumb)" <noreply+crowmagnumb@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Fri, 10 Jan 2025 23:02:33 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3396: SQLData Support
In-Reply-To: <gh-pgjdbc-pgjdbc-3396@github.com>
References: <gh-pgjdbc-pgjdbc-3396@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: crowmagnumb
X-GitHub-Comment-Id: 2584698459
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 3396
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3396#issuecomment-2584698459
Content-Type: text/plain; charset=utf-8

> It also seems to me that if (type == Byte.class ) there is not enough primitive type checking, which is available for all types except byte. Something like this:
> 
> ```
>     if (type == Byte.class || type == byte.class) {
>       return (SQLFunction<String, T>) byteConv;
>     }
> ```
> 
> In the getConverter. We are checking Array. Should we also check SQLXML there?
> 
> p.s I'm sorry for writing this here. I'm just very interested in the functionality that you've implemented.

I just added these. cheers.