Message-ID: <gh-pgjdbc-pgjdbc-3396-c2743911377@github.com>
From: "crowmagnumb (@crowmagnumb)" <noreply+crowmagnumb@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Fri, 21 Mar 2025 16:43:29 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3396: SQLData Support
In-Reply-To: <gh-pgjdbc-pgjdbc-3396@github.com>
References: <gh-pgjdbc-pgjdbc-3396@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: crowmagnumb
X-GitHub-Comment-Id: 2743911377
X-GitHub-Comment-Type: issue_comment
X-GitHub-Edited-At: 2025-03-21T16:43:52Z
X-GitHub-Issue: 3396
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3396#issuecomment-2743911377
Content-Type: text/plain; charset=utf-8

> > looks like code style then we are good to go.
> > @vlsi can you take a look?
> 
> Oops, yeah these were working before I merged main in. I only did that to satisfy myself that it was fine and honestly forgot that it would trigger an auto-update here. Oops. But again, these checks were working before that. I can take a look too.

Ah no, maybe I'll leave it to you @vlsi or at least till you advise me. After adding static to the private methods it then complained about default character sets and I don't know how to proceed with that.