Message-ID: <gh-pgjdbc-pgjdbc-3396-rc2074252613@github.com>
From: "davecramer (@davecramer)" <noreply+davecramer@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Mon, 05 May 2025 21:53:05 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3396: SQLData Support
In-Reply-To: <gh-pgjdbc-pgjdbc-3396@github.com>
References: <gh-pgjdbc-pgjdbc-3396@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: davecramer
X-GitHub-Comment-Id: 2074252613
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: e2494a12810eb7b402d8c51535559606f2e5571a
X-GitHub-Issue: 3396
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/jdbc/SQLDataReader.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3396#discussion_r2074252613
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/jdbc/SQLDataReader.java)

Use PSQLException(GT.tr("An accessible no-arg constructor is required for type {0}", type" ... so we can have translations. State might be SYNTAX_ERROR