Message-ID: <gh-pgjdbc-pgjdbc-3396-rc2074254779@github.com>
From: "davecramer (@davecramer)" <noreply+davecramer@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Mon, 05 May 2025 21:55:33 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3396: SQLData Support
In-Reply-To: <gh-pgjdbc-pgjdbc-3396@github.com>
References: <gh-pgjdbc-pgjdbc-3396@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: davecramer
X-GitHub-Comment-Id: 2074254779
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: e2494a12810eb7b402d8c51535559606f2e5571a
X-GitHub-Issue: 3396
X-GitHub-Line: 70
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/jdbc/SQLDataReader.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3396#discussion_r2074254779
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/jdbc/SQLDataReader.java:70)

It would be useful for future readers to have a comment here showing examples of what would potentially be parsed.

Also some comments in each step such as , found `,` moving to next item. etc.