Message-ID: <gh-pgjdbc-pgjdbc-3409-c2461588384@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Thu, 07 Nov 2024 08:16:31 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3409: feat: add support for plugging in custom HostChooser
In-Reply-To: <gh-pgjdbc-pgjdbc-3409@github.com>
References: <gh-pgjdbc-pgjdbc-3409@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 2461588384
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 3409
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3409#issuecomment-2461588384
Content-Type: text/plain; charset=utf-8

Thank you for the draft, and sorry for the delay with the review. In general, it looks like a good start.

However, it looks like `GlobalHostStatusTracker` duplicates the logic of `registerFailure` and `registerSuccess`, so I would like to make the current host chooser a plugin, so should not rely on `GlobalHostStatusTracker.reportHostStatus` from `ConnectionFactoryImpl`.
In other words, currently the PR suggests a set of new APIs, however, it is not clear if the old balancer could be implemented as an external plugin that uses the new APIs only.

What do you think?