Message-ID: <gh-pgjdbc-pgjdbc-3480-c2592675475@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Wed, 15 Jan 2025 12:26:42 +0000
Subject: Re: [pgjdbc/pgjdbc] issue #3480: 42.7.5 breaks RHEL 8 builds
In-Reply-To: <gh-pgjdbc-pgjdbc-3480@github.com>
References: <gh-pgjdbc-pgjdbc-3480@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 2592675475
X-GitHub-Comment-Type: issue_comment
X-GitHub-Edited-At: 2025-01-15T12:27:28Z
X-GitHub-Issue: 3480
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/issues/3480#issuecomment-2592675475
Content-Type: text/plain; charset=utf-8

It seems like the recent release builds with Copr somehow:
* https://github.com/pgjdbc/pgjdbc/actions/runs/12775033160/job/35610465749
* https://copr.fedorainfracloud.org/coprs/g/pgjdbc/pgjdbc/build/8513341/
* https://download.copr.fedorainfracloud.org/results/@pgjdbc/pgjdbc/fedora-rawhide-x86_64/08513341-postgresql-jdbc/builder-live.log.gz => `+ /usr/bin/python3 /usr/share/java-utils/pom_editor.py pom_xpath_remove 'pom:plugin[pom:artifactId = '\''maven-shade-plugin'\'']'`

See https://github.com/pgjdbc/pgjdbc/blob/032d0e225a91e866d7dae680ebb784507392e803/packaging/rpm/postgresql-jdbc.spec.tpl#L107

In other words, for rpm-like builds we expect to remove shading plugin altogether.
However, the released `pom.xml` can produce both shaded and non-shaded dependencies.

So you could either cut out `maven-shade-plugin` (see `postgresql-jdbc.spec.tpl`) or use `mvn -DskipShadeDependencies=true ....` to avoid shading altogether (see https://github.com/pgjdbc/pgjdbc/blob/032d0e225a91e866d7dae680ebb784507392e803/pgjdbc/reduced-pom.xml#L207C65-L207C93)