pgjdbc/pgjdbc GitHub issues and pull requests (mirror)
help / color / mirror / Atom feedFrom: ecki (@ecki) <[email protected]>
To: pgjdbc/pgjdbc <[email protected]>
Subject: [pgjdbc/pgjdbc] issue #3490: Clarify startup parameter selection since Version 12 for extra_float_digits
Date: Wed, 22 Jan 2025 00:52:43 +0000
Message-ID: <[email protected]> (raw)
This code sends extra_float_digits=2 for older than 9 and newer than 12.
https://github.com/pgjdbc/pgjdbc/blob/032d0e225a91e866d7dae680ebb784507392e803/pgjdbc/src/main/java/...
It probably doesnt matter for newer Servers if 2 or 3, but the comment in the code does not explain this case.
Either remove the <12 condition so it sends 3 for all neuer Servers or explain in the else „also send value 2 for newer servers (since 12 any value bigger than 0 will enable the shortest precise decimal mode).“
I would and a comment clarifying the meaning of 3 for older servers and >0 for newer ones anyway as there to explain the hardcoded values 2 and 3.
view thread (4+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: github://pgjdbc/pgjdbc
Cc: [email protected], [email protected]
Subject: Re: [pgjdbc/pgjdbc] issue #3490: Clarify startup parameter selection since Version 12 for extra_float_digits
In-Reply-To: <<[email protected]>>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox