Message-ID: <gh-pgjdbc-pgjdbc-3493-c2612551346@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Fri, 24 Jan 2025 13:37:36 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3493: chore: add ErrorProne verification to catch bugs ealier
In-Reply-To: <gh-pgjdbc-pgjdbc-3493@github.com>
References: <gh-pgjdbc-pgjdbc-3493@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 2612551346
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 3493
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3493#issuecomment-2612551346
Content-Type: text/plain; charset=utf-8

It looks like this is finalized.

In practice, errorprone does not significantly increase the build time, so it might be worth running it on every build. WDYT?

Currently, I configured it so it executes errorpone only when explicitly asked (e.g. `./gradlew -PenableErrorprone classes` or `./gradlew style`)