Message-ID: <gh-pgjdbc-pgjdbc-3493-c2612723589@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Fri, 24 Jan 2025 14:53:48 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3493: chore: add ErrorProne verification to catch bugs ealier
In-Reply-To: <gh-pgjdbc-pgjdbc-3493@github.com>
References: <gh-pgjdbc-pgjdbc-3493@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 2612723589
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 3493
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3493#issuecomment-2612723589
Content-Type: text/plain; charset=utf-8

> it will clean up a lot of things.

Just for the reference, ErrorProne does not fix issues. It only reports them and suggests fixes.

For example:

```
> Task :postgresql:compileJava
pgjdbc/pgjdbc/src/main/java/org/postgresql/jdbc/PgConnection.java:1741: Note: [MethodCanBeStatic] A private method that does not reference the enclosing instance can be static
  private void checkPermission(SQLPermission sqlPermissionNetworkTimeout) {
  ^
    (see https://errorprone.info/bugpattern/MethodCanBeStatic)
  Did you mean 'private static void checkPermission(SQLPermission sqlPermissionNetworkTimeout) {'?
```