Message-ID: <gh-pgjdbc-pgjdbc-3509-rc1942017397@github.com>
From: "joejensen (@joejensen)" <noreply+joejensen@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Tue, 04 Feb 2025 23:09:21 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3509: Add back application name setting
In-Reply-To: <gh-pgjdbc-pgjdbc-3509-rc1942012936@github.com>
References: <gh-pgjdbc-pgjdbc-3509@github.com> <gh-pgjdbc-pgjdbc-3509-rc1942012936@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: joejensen
X-GitHub-Comment-Id: 1942017397
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 9ef77ad39125a283fe56d42899eac94cea0f2afa
X-GitHub-Issue: 3509
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/core/v3/ConnectionFactoryImpl.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3509#discussion_r1942017397
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/core/v3/ConnectionFactoryImpl.java)

Maybe I'm missing something but isn't the purpose of the minServerVersion, so that we can infer what we expect the minimum version to be?

I'd be happy to add another way(property) of indicating this should happen but it seems redundant.  Not having this occur at startup causes a regression from the last several driver versions for my use case.