Message-ID: <gh-pgjdbc-pgjdbc-3509-rc1942077759@github.com>
From: "joejensen (@joejensen)" <noreply+joejensen@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Wed, 05 Feb 2025 00:12:28 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3509: Add back application name setting
In-Reply-To: <gh-pgjdbc-pgjdbc-3509-rc1942012936@github.com>
References: <gh-pgjdbc-pgjdbc-3509@github.com> <gh-pgjdbc-pgjdbc-3509-rc1942012936@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: joejensen
X-GitHub-Comment-Id: 1942077759
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 9ef77ad39125a283fe56d42899eac94cea0f2afa
X-GitHub-Issue: 3509
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/core/v3/ConnectionFactoryImpl.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3509#discussion_r1942077759
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/core/v3/ConnectionFactoryImpl.java)

I really would like to understand what I am misunderstanding.  Anticipating what the server version will be before connecting seems to be the entire purpose of the assumeMinServerVersion property.  If we remove this use case it does not appear to be used anywhere else.