Message-ID: <gh-pgjdbc-pgjdbc-3509-rc1961992484@github.com>
From: "joejensen (@joejensen)" <noreply+joejensen@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Wed, 19 Feb 2025 16:21:28 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3509: Add back application name setting
In-Reply-To: <gh-pgjdbc-pgjdbc-3509-rc1961882068@github.com>
References: <gh-pgjdbc-pgjdbc-3509@github.com> <gh-pgjdbc-pgjdbc-3509-rc1961882068@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: joejensen
X-GitHub-Comment-Id: 1961992484
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 9ef77ad39125a283fe56d42899eac94cea0f2afa
X-GitHub-Issue: 3509
X-GitHub-Line: 926
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/core/v3/ConnectionFactoryImpl.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3509#discussion_r1961992484
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/core/v3/ConnectionFactoryImpl.java:926)

It can't.  ServerVersion.from(String) converts a null assumeMinServerVersion to a 0, which is what is returned if no min server version was provided.