Message-ID: <gh-pgjdbc-pgjdbc-3513-c2639726396@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Thu, 06 Feb 2025 12:43:24 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3513: feat: enhanced DatabaseMetadata.getIndexInfo() method, added index comment as REMARKS property
In-Reply-To: <gh-pgjdbc-pgjdbc-3513@github.com>
References: <gh-pgjdbc-pgjdbc-3513@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 2639726396
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 3513
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3513#issuecomment-2639726396
Content-Type: text/plain; charset=utf-8

The rest of the methods like `getTables`, `getColumns` include `REMARKS`, so I think the miss of `REMARKS` in `getIndexInfo` is unintentional.

At the same time, adding vendor's columns is allowed:

> Additional columns beyond the columns defined to be returned by the ResultSet object for a given method can be defined by the JDBC driver vendor and must be accessed by their column label.