Message-ID: <gh-pgjdbc-pgjdbc-3526-c2667577841@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Wed, 19 Feb 2025 05:57:07 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3526: Set column name explicitely when using `current_database()` in queries
In-Reply-To: <gh-pgjdbc-pgjdbc-3526@github.com>
References: <gh-pgjdbc-pgjdbc-3526@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 2667577841
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 3526
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3526#issuecomment-2667577841
Content-Type: text/plain; charset=utf-8

Frankly, I see no issues leaving it as `current_database() as current_database`. I would probably prefer this one.

It would make query easier to understand and test. It would naturally avoid "concatenate string sql on every execution" as well.
WDYT?