Message-ID: <gh-pgjdbc-pgjdbc-3526-c2674227030@github.com>
From: "davecramer (@davecramer)" <noreply+davecramer@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Fri, 21 Feb 2025 10:53:17 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3526: Set column name explicitely when using `current_database()` in queries
In-Reply-To: <gh-pgjdbc-pgjdbc-3526@github.com>
References: <gh-pgjdbc-pgjdbc-3526@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: davecramer
X-GitHub-Comment-Id: 2674227030
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 3526
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3526#issuecomment-2674227030
Content-Type: text/plain; charset=utf-8

> Ok, PostgreSQL has a regression test that ensures `current_database()` should return the same value as `current_catalog`: https://github.com/postgres/postgres/blob/7d6d2c4bbd730bd9af191d46d4fb01d5f5c30cf1/src/test/regress/expected/expressions.out#L91-L94
> 
> At the same time, it looks like `current_catalog` was added for the SQL standard compatibility somewhere around 8.4.
> 
> So it is fine to keep using `current_database()`.

Assuming no performance regression